From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkBZC-0002tv-2j for qemu-devel@nongnu.org; Mon, 09 Jan 2012 04:30:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkBZB-0005aj-2h for qemu-devel@nongnu.org; Mon, 09 Jan 2012 04:30:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkBZA-0005af-SO for qemu-devel@nongnu.org; Mon, 09 Jan 2012 04:30:57 -0500 Message-ID: <4F0AB3CA.6090908@redhat.com> Date: Mon, 09 Jan 2012 10:30:50 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1325858346-1071-1-git-send-email-kraxel@redhat.com> <1325858346-1071-7-git-send-email-kraxel@redhat.com> <4F070B34.8030602@weilnetz.de> In-Reply-To: <4F070B34.8030602@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/12] xhci: Initial xHCI implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Hector Martin , qemu-devel@nongnu.org > Hi, > > please use scripts/checkpatch.pl to test this patch. > > It contains several indented statements (if ... else) > without braces. Hmm, indeed, there are a few left. I've fixed lots of them already, I'll do another pass over the code. /me wonders why my commit hook didn't complain. Probably it catched only those code pieces which I've touched. cheers, Gerd