From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkC4b-0002O9-5y for qemu-devel@nongnu.org; Mon, 09 Jan 2012 05:03:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkC4V-0002WQ-8M for qemu-devel@nongnu.org; Mon, 09 Jan 2012 05:03:25 -0500 Received: from thoth.sbs.de ([192.35.17.2]:29931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkC4U-0002W7-Vl for qemu-devel@nongnu.org; Mon, 09 Jan 2012 05:03:19 -0500 Message-ID: <4F0ABB5E.3050306@siemens.com> Date: Mon, 09 Jan 2012 11:03:10 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1326058804-561-1-git-send-email-imammedo@redhat.com> <20120109084752.GG2167@redhat.com> In-Reply-To: <20120109084752.GG2167@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Igor Mammedov , Liu Ping Fan , "qemu-devel@nongnu.org" , "avi@redhat.com" On 2012-01-09 09:47, Gleb Natapov wrote: > On Sun, Jan 08, 2012 at 10:40:04PM +0100, Igor Mammedov wrote: >> Change introduced by e71f08bb4a >> "Fix cpu/pci hotplug to generate level triggered interrupt." >> was lost somewhre along the way. And as result SCI is not sent in >> case of cpu hotplug event. >> Restoring hunk 1 of e71f08bb4a fixes issue. >> > Hmm, I sent similar patch [1] last time someone complained about cpu hotplug > here. Which remind me that in that thread more problem were found in cpu > hotplug. IIRC Jan collected all the patches. Jan, what happened to > them? My patches should have been superseded by the work of Ping Fan on the ICC bus. Jan > > [1] http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/76399 > >> Signed-off-by: Igor Mammedov >> --- >> hw/acpi_piix4.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c >> index 1b35707..741a8cc 100644 >> --- a/hw/acpi_piix4.c >> +++ b/hw/acpi_piix4.c >> @@ -94,7 +94,8 @@ static void pm_update_sci(PIIX4PMState *s) >> ACPI_BITMASK_POWER_BUTTON_ENABLE | >> ACPI_BITMASK_GLOBAL_LOCK_ENABLE | >> ACPI_BITMASK_TIMER_ENABLE)) != 0) || >> - (((s->gpe.sts[0] & s->gpe.en[0]) & PIIX4_PCI_HOTPLUG_STATUS) != 0); >> + (((s->gpe.sts[0] & s->gpe.en[0]) & >> + (PIIX4_CPU_HOTPLUG_STATUS | PIIX4_PCI_HOTPLUG_STATUS)) != 0); >> >> qemu_set_irq(s->irq, sci_level); >> /* schedule a timer interruption if needed */ >> -- >> 1.7.7.5 > > -- > Gleb. -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux