From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkI5g-0005qS-G2 for qemu-devel@nongnu.org; Mon, 09 Jan 2012 11:28:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkI5R-0006ji-6N for qemu-devel@nongnu.org; Mon, 09 Jan 2012 11:28:56 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:45797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkI5R-0006jd-3L for qemu-devel@nongnu.org; Mon, 09 Jan 2012 11:28:41 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Jan 2012 11:28:39 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q09GSG6O3014828 for ; Mon, 9 Jan 2012 11:28:16 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q09GSE0s001762 for ; Mon, 9 Jan 2012 14:28:15 -0200 Message-ID: <4F0B1599.9090609@us.ibm.com> Date: Mon, 09 Jan 2012 10:28:09 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> <4F0B1016.2010600@us.ibm.com> <4F0B12F5.3060109@redhat.com> In-Reply-To: <4F0B12F5.3060109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Please read: make check framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Mark McLoughlin , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Markus Armbruster , =?ISO-8859-1?Q?Andreas_F=E4rber?= , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Stefan Hajnoczi , Stefano Stabellini , Stefan Weil , Riku Voipio , Jan Kiszka , Paul Brook , Daniel Gollub , Luiz Capitulino , "Venkateswararao Jujjuri (JV)" , Richard Henderson , Kevin Wolf , "Vassili Karpov (malc)" , Marcelo Tosatti , Michael Walle , Amit Shah , Paolo Bonzini , Aurelien Jarno On 01/09/2012 10:16 AM, Avi Kivity wrote: > On 01/09/2012 06:04 PM, Anthony Liguori wrote: >> Hi, >> >> I'm going to apply this series quickly and will start running 'make >> check-quick' as part a sniff test before pushing patches. >> >> I'd like to request that all maintainers/submaintainers do the same >> and that everyone contributes unit tests to this target. >> > > Good stuff. > >> The general rules for 'make check-quick': >> >> 1) It must complete in less than 10 minutes start to finish (the >> entire rule). We can re-examine this over time but for now, it seems >> like a reasonable limit. >> >> 2) It must gracefully degrade across architectures/targets. Do not >> assume qemu-system-x86_64 is present or that an arm cross compiler is >> available. >> > > There's a cross compiler in Fedora, arm-gp2x-linux-gcc.x86_64. Is it > suitable for make check? It must degrade gracefully so if you probe for a cross compiler in configure and then disable/enable tests appropriately, that's fine. But 'make check' should succeed and do something useful with only the dependencies required to build QEMU. It can test fewer things of course. Regards, Anthony Liguori >