From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkL4N-0008Kq-Cm for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:39:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkL4M-0004VQ-6U for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:39:47 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:34925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkL4L-0004VD-O9 for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:39:46 -0500 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Jan 2012 14:39:45 -0500 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q09JdgjX301942 for ; Mon, 9 Jan 2012 14:39:42 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q09Jdgwp011203 for ; Mon, 9 Jan 2012 17:39:42 -0200 Message-ID: <4F0B4274.8050302@us.ibm.com> Date: Mon, 09 Jan 2012 13:39:32 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> <1326124572-8312-3-git-send-email-aliguori@us.ibm.com> <4F0B3F51.8060807@suse.de> In-Reply-To: <4F0B3F51.8060807@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 03/11] check-qdict: convert to gtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org, Luiz Capitulino On 01/09/2012 01:26 PM, Andreas Färber wrote: > Am 09.01.2012 16:56, schrieb Anthony Liguori: >> Signed-off-by: Anthony Liguori >> --- >> Makefile | 6 -- >> check-qdict.c | 246 +++++++++++++++++++++++++------------------------------- >> configure | 4 +- >> tests/Makefile | 6 ++ >> 4 files changed, 119 insertions(+), 143 deletions(-) > >> diff --git a/Makefile b/Makefile >> index 80fb512..4823144 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -294,12 +294,6 @@ endif >> test speed: all >> $(MAKE) -C tests/tcg $@ >> >> -.PHONY: check >> -check: $(patsubst %,run-check-%,$(CHECKS)) >> - >> -run-check-%: % >> - ./$< >> - >> .PHONY: TAGS >> TAGS: >> find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags > >> diff --git a/tests/Makefile b/tests/Makefile >> index c11d980..cff9ff3 100644 >> --- a/tests/Makefile >> +++ b/tests/Makefile >> @@ -29,3 +29,9 @@ test-qmp-input-visitor: test-qmp-input-visitor.o $(qobject-obj-y) $(qapi-obj-y) >> test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c test-qmp-commands.h) $(qapi-obj-y) >> test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o $(qapi-dir)/test-qmp-marshal.o module.o >> >> +.PHONY: check >> +check: $(patsubst %,run-check-%,$(CHECKS)) >> + >> +run-check-%: % >> + ./$< >> + > > These should be squashed into 02/11. Unrelated to check-qdict. Thanks. Regards, Anthony Liguori > > Andreas >