From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/11] test: eliminate libcheck tests and have make check use gtester
Date: Tue, 10 Jan 2012 10:17:28 +0100 [thread overview]
Message-ID: <4F0C0228.4000104@redhat.com> (raw)
In-Reply-To: <1326124572-8312-10-git-send-email-aliguori@us.ibm.com>
Hi,
While being at it: The check should not be killed. It should be
replaced by one which checks whenever glib is new enough. Right now
qemu doesn't build on RHEL-5 because the glib shipped with it is too old
to run the tests.
cheers,
Gerd
----------------- [ cut here ] -------------------
CC test-coroutine.o
cc1: warnings being treated as errors
test-coroutine.c: In function 'test_nesting':
test-coroutine.c:92: warning: implicit declaration of function
'g_assert_cmpint'
test-coroutine.c:92: warning: nested extern declaration of 'g_assert_cmpint'
test-coroutine.c:92: error: expected expression before '==' token
test-coroutine.c:93: error: expected expression before '==' token
test-coroutine.c: In function 'test_yield':
test-coroutine.c:122: error: expected expression before '==' token
test-coroutine.c: In function 'perf_lifecycle':
test-coroutine.c:170: warning: implicit declaration of function
'g_test_timer_start'
test-coroutine.c:170: warning: nested extern declaration of
'g_test_timer_start'
test-coroutine.c:175: warning: implicit declaration of function
'g_test_timer_elapsed'
test-coroutine.c:175: warning: nested extern declaration of
'g_test_timer_elapsed'
test-coroutine.c:177: warning: implicit declaration of function
'g_test_message'
test-coroutine.c:177: warning: nested extern declaration of 'g_test_message'
test-coroutine.c: In function 'main':
test-coroutine.c:182: warning: implicit declaration of function
'g_test_init'
test-coroutine.c:182: warning: nested extern declaration of 'g_test_init'
test-coroutine.c:183: warning: implicit declaration of function
'g_test_add_func'
test-coroutine.c:183: warning: nested extern declaration of
'g_test_add_func'
test-coroutine.c:188: warning: implicit declaration of function
'g_test_perf'
test-coroutine.c:188: warning: nested extern declaration of 'g_test_perf'
test-coroutine.c:191: warning: implicit declaration of function 'g_test_run'
test-coroutine.c:191: warning: nested extern declaration of 'g_test_run'
make: *** [test-coroutine.o] Error 1
next prev parent reply other threads:[~2012-01-10 9:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 15:56 [Qemu-devel] [PATCH 01/11] tests: mv tests/* -> tests/tcg Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 02/11] build: split unit test builds to a separate makefile fragment Anthony Liguori
2012-01-09 19:23 ` Andreas Färber
2012-01-09 19:38 ` Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 03/11] check-qdict: convert to gtest Anthony Liguori
2012-01-09 18:27 ` Luiz Capitulino
2012-01-09 19:15 ` Anthony Liguori
2012-01-09 19:37 ` Luiz Capitulino
2012-01-09 19:26 ` Andreas Färber
2012-01-09 19:39 ` Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 04/11] check-qfloat: " Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 05/11] check-qint: " Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 06/11] check-qstring: " Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 07/11] check-qlist: " Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 08/11] check-qjson: " Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 09/11] check-qjson: enable disabled tests Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 10/11] test: eliminate libcheck tests and have make check use gtester Anthony Liguori
2012-01-09 19:35 ` Andreas Färber
2012-01-10 9:17 ` Gerd Hoffmann [this message]
2012-01-10 13:10 ` Anthony Liguori
2012-01-09 15:56 ` [Qemu-devel] [PATCH 11/11] check: add a check-report and check-help target Anthony Liguori
2012-01-09 20:00 ` Andreas Färber
2012-01-09 16:04 ` [Qemu-devel] Please read: make check framework Anthony Liguori
2012-01-09 16:16 ` Avi Kivity
2012-01-09 16:28 ` Anthony Liguori
2012-01-09 16:47 ` Daniel Gollub
2012-01-09 17:47 ` Paul Brook
2012-01-09 19:28 ` Anthony Liguori
2012-01-09 20:57 ` Andreas Färber
2012-01-09 21:42 ` Anthony Liguori
2012-01-09 23:22 ` Andreas Färber
2012-01-09 23:56 ` Anthony Liguori
2012-01-10 9:57 ` Kevin Wolf
2012-01-10 13:11 ` Anthony Liguori
2012-01-10 14:49 ` Andreas Färber
2012-01-10 15:39 ` Peter Maydell
2012-01-09 20:00 ` Stefan Weil
2012-01-10 8:39 ` Stefan Hajnoczi
2012-01-10 13:21 ` Luiz Capitulino
2012-01-09 19:18 ` [Qemu-devel] [PATCH 01/11] tests: mv tests/* -> tests/tcg Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C0228.4000104@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).