From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RkXps-00078u-T1
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 04:17:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RkXpl-0003Bk-2A
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 04:17:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10021)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RkXpk-0003BN-R0
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 04:17:33 -0500
Message-ID: <4F0C0228.4000104@redhat.com>
Date: Tue, 10 Jan 2012 10:17:28 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com>
	<1326124572-8312-10-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1326124572-8312-10-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/11] test: eliminate libcheck tests and
 have	make check use gtester
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

While being at it: The check should not be killed.  It should be
replaced by one which checks whenever glib is new enough.  Right now
qemu doesn't build on RHEL-5 because the glib shipped with it is too old
to run the tests.

cheers,
  Gerd

----------------- [ cut here ] -------------------
  CC    test-coroutine.o
cc1: warnings being treated as errors
test-coroutine.c: In function 'test_nesting':
test-coroutine.c:92: warning: implicit declaration of function
'g_assert_cmpint'
test-coroutine.c:92: warning: nested extern declaration of 'g_assert_cmpint'
test-coroutine.c:92: error: expected expression before '==' token
test-coroutine.c:93: error: expected expression before '==' token
test-coroutine.c: In function 'test_yield':
test-coroutine.c:122: error: expected expression before '==' token
test-coroutine.c: In function 'perf_lifecycle':
test-coroutine.c:170: warning: implicit declaration of function
'g_test_timer_start'
test-coroutine.c:170: warning: nested extern declaration of
'g_test_timer_start'
test-coroutine.c:175: warning: implicit declaration of function
'g_test_timer_elapsed'
test-coroutine.c:175: warning: nested extern declaration of
'g_test_timer_elapsed'
test-coroutine.c:177: warning: implicit declaration of function
'g_test_message'
test-coroutine.c:177: warning: nested extern declaration of 'g_test_message'
test-coroutine.c: In function 'main':
test-coroutine.c:182: warning: implicit declaration of function
'g_test_init'
test-coroutine.c:182: warning: nested extern declaration of 'g_test_init'
test-coroutine.c:183: warning: implicit declaration of function
'g_test_add_func'
test-coroutine.c:183: warning: nested extern declaration of
'g_test_add_func'
test-coroutine.c:188: warning: implicit declaration of function
'g_test_perf'
test-coroutine.c:188: warning: nested extern declaration of 'g_test_perf'
test-coroutine.c:191: warning: implicit declaration of function 'g_test_run'
test-coroutine.c:191: warning: nested extern declaration of 'g_test_run'
make: *** [test-coroutine.o] Error 1