From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkb6Z-0007VH-Bn for qemu-devel@nongnu.org; Tue, 10 Jan 2012 07:47:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rkb6Y-0003cL-A1 for qemu-devel@nongnu.org; Tue, 10 Jan 2012 07:47:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49031 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkb6X-0003c8-W5 for qemu-devel@nongnu.org; Tue, 10 Jan 2012 07:47:06 -0500 Message-ID: <4F0C32E5.20702@suse.de> Date: Tue, 10 Jan 2012 13:45:25 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com> <1326128349-3465-1-git-send-email-mark.langsdorf@calxeda.com> <1326128349-3465-7-git-send-email-mark.langsdorf@calxeda.com> In-Reply-To: <1326128349-3465-7-git-send-email-mark.langsdorf@calxeda.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] arm: Remove incorrect and misleading comment in arm_timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Langsdorf Cc: i.mitsyanko@gmail.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Am 09.01.2012 17:59, schrieb Mark Langsdorf: > Signed-off-by: Mark Langsdorf > --- > hw/arm_timer.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/arm_timer.c b/hw/arm_timer.c > index 60e1c63..15d493f 100644 > --- a/hw/arm_timer.c > +++ b/hw/arm_timer.c > @@ -272,11 +272,8 @@ static int sp804_init(SysBusDevice *dev) > =20 > qi =3D qemu_allocate_irqs(sp804_set_irq, s, 2); > sysbus_init_irq(dev, &s->irq); > - /* The timers are configurable between 32kHz and 1MHz > - * defaulting to 1MHz but overrideable as individual properties */ Wasn't this comment added by your "arm: Set frequencies for arm_timer"? I didn't see a message indicating that series has been applied yet, so you should probably fix the comment in the original patch instead of in a follow-up patch. The point of adding the highbank emulation was to see if the patches are sufficient, no? Else, the commit message does not indicate what is incorrect/misleading about it. Andreas > s->timer[0] =3D arm_timer_init(s->freq0); > s->timer[1] =3D arm_timer_init(s->freq1); > - > s->timer[0]->irq =3D qi[0]; > s->timer[1]->irq =3D qi[1]; > memory_region_init_io(&s->iomem, &sp804_ops, s, "sp804", 0x1000); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg