From: Anthony Liguori <aliguori@us.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Chris Wright" <chrisw@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Corey Bryant" <coreyb@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Avi Kivity" <avi@redhat.com>, "Stefan Weil" <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [RFC] QEMU Code Audit Team
Date: Tue, 10 Jan 2012 07:22:13 -0600 [thread overview]
Message-ID: <4F0C3B85.7030600@us.ibm.com> (raw)
In-Reply-To: <4F0C360A.2090100@redhat.com>
On 01/10/2012 06:58 AM, Kevin Wolf wrote:
> Probably we need to attack the reviewing problem first: That I review
> all block patches myself worked well as long as we were two or three
> people in that area, but today it doesn't scale any more without
> lowering the review standards - and I don't want to do that. Maybe we
> should introduce something like "One Reviewed-by buys you two
> Signed-off-bys for your own patches" ;-)
I think one thing that helps is to make sure for maintainers to include
Reviewed-bys in commits. The script I use (below) takes a mbox with the full
thread and folks Reviewed-by/Tested-bys into the original patch spitting out an
mbox with just the patches and tags.
That way people are getting credit in git for doing reviews. It's a small
incentive but every little bit helps.
http://git.codemonkey.ws/cgit/mbox-filter.git/
Regards,
Anthony Liguori
>
> I can imagine that other subsystem maintainers have similar problems.
>
> Kevin
>
next prev parent reply other threads:[~2012-01-10 13:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 15:19 [Qemu-devel] [RFC] QEMU Code Audit Team Anthony Liguori
2012-01-06 16:01 ` Stefan Hajnoczi
2012-01-06 16:14 ` Stefan Weil
2012-01-06 16:08 ` Corey Bryant
2012-01-06 17:25 ` Chris Wright
2012-01-08 14:01 ` Dor Laor
2012-01-08 16:54 ` Stefan Hajnoczi
2012-01-06 17:37 ` Chris Wright
2012-01-06 20:02 ` Andreas Färber
2012-01-06 20:42 ` Anthony Liguori
2012-01-07 3:09 ` Peter Maydell
2012-01-07 10:42 ` Stefan Hajnoczi
2012-01-10 12:58 ` Kevin Wolf
2012-01-10 13:22 ` Anthony Liguori [this message]
2012-01-10 13:33 ` Kevin Wolf
2012-01-10 13:39 ` Andreas Färber
2012-01-10 14:55 ` Kevin Wolf
2012-01-10 15:41 ` Peter Maydell
2012-01-10 16:31 ` Andreas Färber
2012-01-10 14:21 ` Anthony Liguori
2012-01-10 3:31 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C3B85.7030600@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).