From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RkW1P-0004pm-0D
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 02:21:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RkW1O-0001gq-6m
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 02:21:26 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:55662)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RkW1O-0001gX-2S
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 02:21:26 -0500
Received: by iagw33 with SMTP id w33so565623iag.4
	for <qemu-devel@nongnu.org>; Mon, 09 Jan 2012 23:21:24 -0800 (PST)
Message-ID: <4F0C6580.3000908@gmail.com>
Date: Wed, 11 Jan 2012 01:21:20 +0900
From: Benjamin <mlspirat42@gmail.com>
MIME-Version: 1.0
References: <1322596506-31056-1-git-send-email-mlspirat42@gmail.com>
	<CAJSP0QWbcwUFv-0yMx7hvJcsi+X3+VeLvpJA73OEK1taKXbtvw@mail.gmail.com>
In-Reply-To: <CAJSP0QWbcwUFv-0yMx7hvJcsi+X3+VeLvpJA73OEK1taKXbtvw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: andreas.faerber@web.de, jan.kiszka@web.de, qemu-devel@nongnu.org

On 11/29/11 20:52, Stefan Hajnoczi wrote:
> On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<mlspirat42@gmail.com>  wrote:
>>
>> Signed-off-by: Benjamin<mlspirat42@gmail.com>
>> ---
>>   net.c           |    6 ++++-
>>   net/socket.c    |   73 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   qemu-options.hx |    2 +
>>   3 files changed, 78 insertions(+), 3 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>
>> +    s = net_socket_fd_init(vlan, model, name, fd, 0);
>> +    if (!s) {
>> +        return -1;
>> +    }
>
> I'll add a TODO to my list about net_socket_fd_init().  It does not
> consistently take ownership of fd.  It may return NULL without closing
> it, but then again it might close it on error in another code path :(.
>   Don't worry about this for now.
>
> Stefan

Me again, is it supposed to take that long before the patch is
accepted? Did I forget something?

Regards,

Benjamin