From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkg1C-0001gX-7V for qemu-devel@nongnu.org; Tue, 10 Jan 2012 13:01:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rkg15-000466-DC for qemu-devel@nongnu.org; Tue, 10 Jan 2012 13:01:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40035 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkg15-00045V-2x for qemu-devel@nongnu.org; Tue, 10 Jan 2012 13:01:47 -0500 Message-ID: <4F0C7CA6.5020202@suse.de> Date: Tue, 10 Jan 2012 19:00:06 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com> <1326128349-3465-1-git-send-email-mark.langsdorf@calxeda.com> <1326128349-3465-7-git-send-email-mark.langsdorf@calxeda.com> <4F0C32E5.20702@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] arm: Remove incorrect and misleading comment in arm_timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Am 10.01.2012 16:35, schrieb Peter Maydell: > On 10 January 2012 12:45, Andreas F=C3=A4rber wrote: >> Am 09.01.2012 17:59, schrieb Mark Langsdorf: >>> Signed-off-by: Mark Langsdorf >>> --- >>> hw/arm_timer.c | 3 --- >>> 1 files changed, 0 insertions(+), 3 deletions(-) >>> >>> diff --git a/hw/arm_timer.c b/hw/arm_timer.c >>> index 60e1c63..15d493f 100644 >>> --- a/hw/arm_timer.c >>> +++ b/hw/arm_timer.c >>> @@ -272,11 +272,8 @@ static int sp804_init(SysBusDevice *dev) >>> >>> qi =3D qemu_allocate_irqs(sp804_set_irq, s, 2); >>> sysbus_init_irq(dev, &s->irq); >>> - /* The timers are configurable between 32kHz and 1MHz >>> - * defaulting to 1MHz but overrideable as individual properties = */ >> >> Wasn't this comment added by your "arm: Set frequencies for arm_timer"= ? >> >> I didn't see a message indicating that series has been applied yet, so >> you should probably fix the comment in the original patch instead of i= n >> a follow-up patch. The point of adding the highbank emulation was to s= ee >> if the patches are sufficient, no? >=20 > It has been applied: commit 104a26a236. The v5 various ARM fixes series doesn't say so, only 3/7 v9 has such a notice. (Just like unthreaded patches a PULL and the original series do drift apart.) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg