From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkshS-0005bq-0Q for qemu-devel@nongnu.org; Wed, 11 Jan 2012 02:34:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkshQ-0000sT-TP for qemu-devel@nongnu.org; Wed, 11 Jan 2012 02:34:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkshQ-0000sN-Mr for qemu-devel@nongnu.org; Wed, 11 Jan 2012 02:34:20 -0500 Message-ID: <4F0D3B76.8000709@redhat.com> Date: Wed, 11 Jan 2012 15:34:14 +0800 From: Osier Yang MIME-Version: 1.0 References: <1307127842-12102-1-git-send-email-lcapitulino@redhat.com> <4EF0300B.8060903@redhat.com> <20120103172826.3bc0199c@doriath> In-Reply-To: <20120103172826.3bc0199c@doriath> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 00/10]: QMP/HMP: Introduce tray handling commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, amit.shah@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com On 2012=E5=B9=B401=E6=9C=8804=E6=97=A5 03:28, Luiz Capitulino wrote: > On Tue, 20 Dec 2011 14:49:47 +0800 > Osier Yang wrote: > >> On 2011=E5=B9=B406=E6=9C=8804=E6=97=A5 03:03, Luiz Capitulino wrote: >>> In a recent discussion on the mailing list regarding the introduction= of >>> the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events[1], it was mentioned = that >>> we need to fix the eject command and maybe introduce new commands fir= st. >>> >>> Here's a my proposal. >>> >>> This series introduces three new commands: >>> >>> o blockdev-tray-open: opens the drive tray. Also Supports removing= the inserted >>> media. The BLOCK_TRAY_OPEN event is emitted if this command succ= eeds. >>> o blockdev-tray-close: closes a drive tray. The BLOCK_TRAY_CLOSE e= vent is >>> emitted. >>> o blockdev-media-insert: Inserts a media in the tray. The tray mus= t empty >>> and already opened. No event is emitted. >>> >>> The existing 'eject' and 'change' commands are completely rewriten in= terms >>> of the new commands. Besides fixing some bad behaviors, this also mak= es it >>> possible for the events to be automtically emitted. >>> >>> Ejecting a device inside the guest (or closing its tray) also causes = the >>> events to be emitted. >>> >>> Everything which applies for the virtual tray seems to work as expect= ed for >>> the host's tray. But more testing is needed. >>> >> >> Hi, Luiz >> >> Does it still plan to introduce new commands for tray& media >> management? > > Yes, but I'm not exactly sure when. Do you need it? Not necessary, just wanted to confirm if I could wait for a while to get those support in together when creating similiar support in libvirt layer. > >> and by the way, I'd agree with Markus more for >> seperating the commands for tray and media management. It >> makes thing simpler and more clear from a user's point of >> view. >> >> Regards, >> Osier >> > >