From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl0XJ-0006os-9d for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:56:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl0XG-0007Kp-I7 for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:56:25 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:47829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl0XG-0007J0-Fh for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:56:22 -0500 Received: from /spool/local by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Jan 2012 10:56:06 -0500 Message-ID: <4F0DB018.5080302@linux.vnet.ibm.com> Date: Wed, 11 Jan 2012 10:51:52 -0500 From: Stefan Berger MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] hmp: Fix freeing of PciInfoList List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: qemu-devel Remember the original PciInfoList in info_list and use the info variable to traverse the list. Signed-off-by: Stefan Berger --- hmp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Index: qemu-git.pt/hmp.c =================================================================== --- qemu-git.pt.orig/hmp.c +++ qemu-git.pt/hmp.c @@ -486,17 +486,17 @@ static void hmp_info_pci_device(Monitor void hmp_info_pci(Monitor *mon) { - PciInfoList *info; + PciInfoList *info_list, info; Error *err = NULL; - info = qmp_query_pci(&err); + info_list = qmp_query_pci(&err); if (err) { monitor_printf(mon, "PCI devices not supported\n"); error_free(err); return; } - for (; info; info = info->next) { + for (info = info_list; info; info = info->next) { PciDeviceInfoList *dev; for (dev = info->value->devices; dev; dev = dev->next) { @@ -504,7 +504,7 @@ void hmp_info_pci(Monitor *mon) } } - qapi_free_PciInfoList(info); + qapi_free_PciInfoList(info_list); } void hmp_info_tpm(Monitor *mon)