From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl4py-0002fh-GM for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:31:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl4px-0000NG-Bd for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:31:58 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53182 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl4px-0000N6-2z for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:31:57 -0500 Message-ID: <4F0DF154.7020103@suse.de> Date: Wed, 11 Jan 2012 21:30:12 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1326054468-5361-1-git-send-email-hpoussin@reactos.org> <1326054468-5361-9-git-send-email-hpoussin@reactos.org> In-Reply-To: <1326054468-5361-9-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/10] fdc: add CCR (Configuration Control Register) write register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Kevin Wolf , qemu-devel@nongnu.org Am 08.01.2012 21:27, schrieb Herv=C3=A9 Poussineau: >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/fdc.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/fdc.c b/hw/fdc.c > index ddfa91f..67cd14f 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -227,6 +227,7 @@ static void fdctrl_write_rate(FDCtrl *fdctrl, uint3= 2_t value); > static uint32_t fdctrl_read_data(FDCtrl *fdctrl); > static void fdctrl_write_data(FDCtrl *fdctrl, uint32_t value); > static uint32_t fdctrl_read_dir(FDCtrl *fdctrl); > +static void fdctrl_write_ccr(FDCtrl *fdctrl, uint32_t value); > =20 > enum { > FD_DIR_WRITE =3D 0, > @@ -251,6 +252,7 @@ enum { > FD_REG_DSR =3D 0x04, > FD_REG_FIFO =3D 0x05, > FD_REG_DIR =3D 0x07, > + FD_REG_CCR =3D 0x07, I'm not familiar with FDCs, so this reads weird: Do DIR and CCR share the same address, with DIR being read-only and CCR write-only? If so, an explanatory sentence in the commit message would be nice. (dito for most other patches in the series) > }; > =20 > enum { > @@ -495,6 +497,8 @@ static void fdctrl_write (void *opaque, uint32_t re= g, uint32_t value) > case FD_REG_FIFO: > fdctrl_write_data(fdctrl, value); > break; > + case FD_REG_CCR: > + fdctrl_write_ccr(fdctrl, value); break; please, to avoid future errors or complaints by static analysis tools. Andreas > default: > break; > } --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg