From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl57e-0008I8-7U for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:50:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl57Z-00042t-Jd for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:50:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53612 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl57Z-00042J-EF for qemu-devel@nongnu.org; Wed, 11 Jan 2012 15:50:09 -0500 Message-ID: <4F0DF597.1040907@suse.de> Date: Wed, 11 Jan 2012 21:48:23 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1326054468-5361-1-git-send-email-hpoussin@reactos.org> <1326054468-5361-11-git-send-email-hpoussin@reactos.org> In-Reply-To: <1326054468-5361-11-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Kevin Wolf , qemu-devel@nongnu.org Am 08.01.2012 21:27, schrieb Herv=C3=A9 Poussineau: >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/fdc.c | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) >=20 > diff --git a/hw/fdc.c b/hw/fdc.c > index 7af0f7e..a23fb1e 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -932,13 +933,7 @@ static uint32_t fdctrl_read_dir(FDCtrl *fdctrl) > { > uint32_t retval =3D 0; > =20 > - if (fdctrl_media_changed(drv0(fdctrl)) > - || fdctrl_media_changed(drv1(fdctrl)) > -#if MAX_FD =3D=3D 4 > - || fdctrl_media_changed(drv2(fdctrl)) > - || fdctrl_media_changed(drv3(fdctrl)) > -#endif > - ) > + if (fdctrl_media_changed(get_cur_drv(fdctrl))) > retval |=3D FD_DIR_DSKCHG; Braces :) (Most famous review comment...) Andreas > if (retval !=3D 0) { > FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retv= al); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg