From: Gerd Hoffmann <kraxel@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: Kevin O'Connor <kevin@koconnor.net>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms
Date: Thu, 12 Jan 2012 08:58:39 +0100 [thread overview]
Message-ID: <4F0E92AF.6010001@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1201120741150.28218@bbs.intern>
Hi,
> I'm not sure about the consequences (hotplugging feature, etc.) when
> changing it to romfile as in other PCI devices.
There should be no noticable difference.
> Also the patch is more
> generic and supports static and dynamic devices (hotplugable and
> possible future devices).
Hotplug works just fine for the other pci devices.
> Patch supports without hotplugging both
> options to disable the romfile:
> ,romfile=
> ,romfile=disabled
That should be a separate patch. And it should update
pci_add_option_rom() so it works equally for all pci devices.
> And the patch has already been tested ...
Well, it adds a bunch of code which would not be needed in the first
place if you would simply make use of the romfile support of the pci layer.
cheers,
Gerd
next prev parent reply other threads:[~2012-01-12 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 11:55 [Qemu-devel] [PATCH] network: Added option to disable NIC option roms Gerhard Wiesinger
2012-01-08 16:40 ` Stefan Hajnoczi
2012-01-08 20:56 ` Gerhard Wiesinger
2012-01-09 8:06 ` Stefan Hajnoczi
2012-01-09 9:15 ` Gerd Hoffmann
2012-01-12 6:45 ` Gerhard Wiesinger
2012-01-12 7:58 ` Gerd Hoffmann [this message]
2012-01-25 21:08 ` Gerhard Wiesinger
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:01 Gerhard Wiesinger
2012-01-26 7:45 ` Markus Armbruster
2012-01-26 10:45 ` Gerd Hoffmann
2012-01-26 11:00 ` Markus Armbruster
2012-01-27 6:56 ` Gerhard Wiesinger
2012-01-27 16:02 ` Gerhard Wiesinger
2012-02-13 6:23 ` Gerhard Wiesinger
2012-02-16 6:41 ` Gerhard Wiesinger
2012-02-01 22:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0E92AF.6010001@redhat.com \
--to=kraxel@redhat.com \
--cc=gleb@redhat.com \
--cc=kevin@koconnor.net \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).