From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlFYc-0006s8-RT for qemu-devel@nongnu.org; Thu, 12 Jan 2012 02:58:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlFYb-0005YG-OX for qemu-devel@nongnu.org; Thu, 12 Jan 2012 02:58:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlFYb-0005Y8-FT for qemu-devel@nongnu.org; Thu, 12 Jan 2012 02:58:45 -0500 Message-ID: <4F0E92AF.6010001@redhat.com> Date: Thu, 12 Jan 2012 08:58:39 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <4F0AB023.5040705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: Kevin O'Connor , qemu-devel@nongnu.org, Gleb Natapov Hi, > I'm not sure about the consequences (hotplugging feature, etc.) when > changing it to romfile as in other PCI devices. There should be no noticable difference. > Also the patch is more > generic and supports static and dynamic devices (hotplugable and > possible future devices). Hotplug works just fine for the other pci devices. > Patch supports without hotplugging both > options to disable the romfile: > ,romfile= > ,romfile=disabled That should be a separate patch. And it should update pci_add_option_rom() so it works equally for all pci devices. > And the patch has already been tested ... Well, it adds a bunch of code which would not be needed in the first place if you would simply make use of the romfile support of the pci layer. cheers, Gerd