* [Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality
@ 2012-01-11 19:53 Gregory Farnum
2012-01-12 9:40 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Gregory Farnum @ 2012-01-11 19:53 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, ceph-devel
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
---
Remove redundant warnings and add Kevin to the CC.
block/rbd.c | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 7a2384c..475e362 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -787,6 +787,26 @@ static int qemu_rbd_snap_create(BlockDriverState *bs,
return 0;
}
+static int qemu_rbd_snap_remove(BlockDriverState *bs,
+ const char *snapshot_name)
+{
+ BDRVRBDState *s = bs->opaque;
+ int r;
+
+ r = rbd_snap_remove(s->image, snapshot_name);
+ return r;
+}
+
+static int qemu_rbd_snap_rollback(BlockDriverState *bs,
+ const char *snapshot_name)
+{
+ BDRVRBDState *s = bs->opaque;
+ int r;
+
+ r = rbd_snap_rollback(s->image, snapshot_name);
+ return r;
+}
+
static int qemu_rbd_snap_list(BlockDriverState *bs,
QEMUSnapshotInfo **psn_tab)
{
@@ -860,7 +880,9 @@ static BlockDriver bdrv_rbd = {
.bdrv_co_flush_to_disk = qemu_rbd_co_flush,
.bdrv_snapshot_create = qemu_rbd_snap_create,
+ .bdrv_snapshot_delete = qemu_rbd_snap_remove,
.bdrv_snapshot_list = qemu_rbd_snap_list,
+ .bdrv_snapshot_goto = qemu_rbd_snap_rollback,
};
static void bdrv_rbd_init(void)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality
2012-01-11 19:53 [Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality Gregory Farnum
@ 2012-01-12 9:40 ` Stefan Hajnoczi
2012-01-12 9:51 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-01-12 9:40 UTC (permalink / raw)
To: Gregory Farnum; +Cc: kwolf, ceph-devel, qemu-devel
On Wed, Jan 11, 2012 at 7:53 PM, Gregory Farnum
<gregory.farnum@dreamhost.com> wrote:
> Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
> ---
> Remove redundant warnings and add Kevin to the CC.
>
> block/rbd.c | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality
2012-01-12 9:40 ` Stefan Hajnoczi
@ 2012-01-12 9:51 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2012-01-12 9:51 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Gregory Farnum, ceph-devel, qemu-devel
Am 12.01.2012 10:40, schrieb Stefan Hajnoczi:
> On Wed, Jan 11, 2012 at 7:53 PM, Gregory Farnum
> <gregory.farnum@dreamhost.com> wrote:
>> Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
>> ---
>> Remove redundant warnings and add Kevin to the CC.
>>
>> block/rbd.c | 22 ++++++++++++++++++++++
>> 1 files changed, 22 insertions(+), 0 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-12 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 19:53 [Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality Gregory Farnum
2012-01-12 9:40 ` Stefan Hajnoczi
2012-01-12 9:51 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).