From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlKRN-0006ml-IJ for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:11:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlKRH-0005rv-M2 for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:11:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58482 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlKRH-0005rp-AL for qemu-devel@nongnu.org; Thu, 12 Jan 2012 08:11:31 -0500 Message-ID: <4F0EDB98.9050306@suse.de> Date: Thu, 12 Jan 2012 14:09:44 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1326213943-878-1-git-send-email-mark.langsdorf@calxeda.com> <1326299490-10780-1-git-send-email-mark.langsdorf@calxeda.com> <1326299490-10780-6-git-send-email-mark.langsdorf@calxeda.com> <4F0ED646.1040206@samsung.com> In-Reply-To: <4F0ED646.1040206@samsung.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v9 5/6] arm: SoC model for Calxeda Highbank List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: i.mitsyanko@samsung.com Cc: peter.maydell@linaro.org, Mark Langsdorf , qemu-devel@nongnu.org, Rob Herring , Paul Brook , edgar.iglesias@gmail.com Am 12.01.2012 13:47, schrieb Mitsyanko Igor: > On 01/11/2012 08:31 PM, Mark Langsdorf wrote: >> + sysram =3D g_new(MemoryRegion, 1); >> + memory_region_init_ram(sysram, "highbank.sysram", 0x8000); >> + memory_region_add_subregion(sysmem, 0xfff88000, sysram); >> + if (bios_name !=3D NULL) { >> + sysboot_filename =3D qemu_find_file(QEMU_FILE_TYPE_BIOS, >> bios_name); >> + if (sysboot_filename !=3D NULL) { >> + uint32_t filesize =3D get_image_size(sysboot_filename); >> + if (load_image_targphys("sysram.bin", 0xfff88000, >> filesize)< 0) { >> + hw_error("Unable to load %s\n", bios_name); >> + } >=20 > Probably should be > if (load_image_targphys(sysboot_filename, 0xfff88000, 0x8000)< 0) { > and then you don't need "uint32_t filesize" at all. You need it either way; if you use 0x8000 there, you need to check if filesize is actually 0x8000. Doing it this way allows to load smaller files; a check for larger files should be added though. Thanks for making me aware. >> + dev =3D qdev_create(NULL, "l2x0"); >> + qdev_init_nofail(dev); >> + busdev =3D sysbus_from_qdev(dev); >> + sysbus_mmio_map(busdev, 0, 0xfff12000); >=20 >> + dev =3D qdev_create(NULL, "highbank-regs"); >> + qdev_init_nofail(dev); >> + busdev =3D sysbus_from_qdev(dev); >> + sysbus_mmio_map(busdev, 0, 0xfff3c000); >> + >=20 > You can use sysbus_create_simple() here (of course, if you didn't avoid > it intentionally for some reason). Depends on how you read this: /* Legacy helper function for creating devices. */ DeviceState *sysbus_create_varargs(const char *name, target_phys_addr_t addr, ...); DeviceState *sysbus_try_create_varargs(const char *name, target_phys_addr_t addr, ...); static inline DeviceState *sysbus_create_simple(const char *name, target_phys_addr_t addr, qemu_irq irq) { return sysbus_create_varargs(name, addr, irq, NULL); } I interpret it as sysbus_create_simple() using deprecated sysbus_create_varargs() and therefore being deprecated, too. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg