From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlLSI-0002by-P4 for qemu-devel@nongnu.org; Thu, 12 Jan 2012 09:16:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlLSE-0008VZ-RC for qemu-devel@nongnu.org; Thu, 12 Jan 2012 09:16:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlLSE-0008VS-Hf for qemu-devel@nongnu.org; Thu, 12 Jan 2012 09:16:34 -0500 Message-ID: <4F0EEB3E.9050405@redhat.com> Date: Thu, 12 Jan 2012 16:16:30 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1325068018-19290-1-git-send-email-avi@redhat.com> In-Reply-To: <1325068018-19290-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix qapi code generation fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org On 12/28/2011 12:26 PM, Avi Kivity wrote: > The fixes to qapi code generation had multiple bugs: > - the Null class used to drop output was missing some methods > - in some scripts it was never instantiated, leading to a None return, > which is missing even more methods > - the --source and --header options were swapped > > Luckily, all those bugs were hidden by a makefile bug which caused the > old behaviour (with the race) to be invoked. Pings. -- error compiling committee.c: too many arguments to function