* [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code
@ 2012-01-12 9:05 Lai Jiangshan
2012-01-12 9:05 ` [Qemu-devel] [PATCH 2/2] cleanup, save a syscall Lai Jiangshan
2012-01-12 16:53 ` [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Lai Jiangshan @ 2012-01-12 9:05 UTC (permalink / raw)
To: Anthony Liguori
Cc: Lai Jiangshan, Jan Kara, Avi Kivity, qemu-devel@nongnu.org
These two blocks of code are exactly the same, remove one.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
cpus.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/cpus.c b/cpus.c
index 857f96f..f45a438 100644
--- a/cpus.c
+++ b/cpus.c
@@ -565,14 +565,6 @@ static void qemu_kvm_init_cpu_signals(CPUState *env)
fprintf(stderr, "kvm_set_signal_mask: %s\n", strerror(-r));
exit(1);
}
-
- sigdelset(&set, SIG_IPI);
- sigdelset(&set, SIGBUS);
- r = kvm_set_signal_mask(env, &set);
- if (r) {
- fprintf(stderr, "kvm_set_signal_mask: %s\n", strerror(-r));
- exit(1);
- }
}
static void qemu_tcg_init_cpu_signals(void)
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] [PATCH 2/2] cleanup, save a syscall
2012-01-12 9:05 [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Lai Jiangshan
@ 2012-01-12 9:05 ` Lai Jiangshan
2012-01-12 16:53 ` [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Lai Jiangshan @ 2012-01-12 9:05 UTC (permalink / raw)
To: Anthony Liguori
Cc: Lai Jiangshan, Jan Kara, Avi Kivity, qemu-devel@nongnu.org
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
main-loop.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/main-loop.c b/main-loop.c
index 60e9748..692381c 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -142,14 +142,12 @@ static int qemu_signal_init(void)
*/
sigemptyset(&set);
sigaddset(&set, SIG_IPI);
- pthread_sigmask(SIG_BLOCK, &set, NULL);
-
- sigemptyset(&set);
sigaddset(&set, SIGIO);
sigaddset(&set, SIGALRM);
sigaddset(&set, SIGBUS);
pthread_sigmask(SIG_BLOCK, &set, NULL);
+ sigdelset(&set, SIG_IPI);
sigfd = qemu_signalfd(&set);
if (sigfd == -1) {
fprintf(stderr, "failed to create signalfd\n");
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code
2012-01-12 9:05 [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Lai Jiangshan
2012-01-12 9:05 ` [Qemu-devel] [PATCH 2/2] cleanup, save a syscall Lai Jiangshan
@ 2012-01-12 16:53 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2012-01-12 16:53 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: Jan Kara, Avi Kivity, qemu-devel@nongnu.org
On 01/12/2012 03:05 AM, Lai Jiangshan wrote:
> These two blocks of code are exactly the same, remove one.
>
> Signed-off-by: Lai Jiangshan<laijs@cn.fujitsu.com>
Applied all. Thanks.
Regards,
Anthony Liguori
> ---
> cpus.c | 8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 857f96f..f45a438 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -565,14 +565,6 @@ static void qemu_kvm_init_cpu_signals(CPUState *env)
> fprintf(stderr, "kvm_set_signal_mask: %s\n", strerror(-r));
> exit(1);
> }
> -
> - sigdelset(&set, SIG_IPI);
> - sigdelset(&set, SIGBUS);
> - r = kvm_set_signal_mask(env,&set);
> - if (r) {
> - fprintf(stderr, "kvm_set_signal_mask: %s\n", strerror(-r));
> - exit(1);
> - }
> }
>
> static void qemu_tcg_init_cpu_signals(void)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-12 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 9:05 [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Lai Jiangshan
2012-01-12 9:05 ` [Qemu-devel] [PATCH 2/2] cleanup, save a syscall Lai Jiangshan
2012-01-12 16:53 ` [Qemu-devel] [PATCH 1/2] cleanup, Remove duplicated code Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).