From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RljSs-000206-UN for qemu-devel@nongnu.org; Fri, 13 Jan 2012 10:54:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RljSn-0001hP-58 for qemu-devel@nongnu.org; Fri, 13 Jan 2012 10:54:50 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:63622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RljSn-0001hL-1A for qemu-devel@nongnu.org; Fri, 13 Jan 2012 10:54:45 -0500 Received: by ghbg15 with SMTP id g15so1104396ghb.4 for ; Fri, 13 Jan 2012 07:54:44 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F1053BF.2060601@redhat.com> Date: Fri, 13 Jan 2012 16:54:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1321898431-18449-1-git-send-email-pbonzini@redhat.com> <4EFDDFA0.5060701@redhat.com> In-Reply-To: <4EFDDFA0.5060701@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Fixes to the rtc device model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/30/2011 04:58 PM, Paolo Bonzini wrote: > On 11/21/2011 07:00 PM, Paolo Bonzini wrote: >> Here are a bunch of fixes for the rtc that I found while reading >> the code. Might be for 1.0 or 1.1, at your choice. >> >> I also have a fix for at least one relatively important bug: when writing >> register B unmasks a pending interrupt, the IRQ line should be raised. >> However, the fix is a bit invasive so I am not posting it yet. >> >> Paolo Bonzini (4): >> rtc: fix 12-hour mode >> rtc: raise AF bit when the alarm is encountered but AIE=0 >> rtc: raise PF bit when the periodic timer triggers but PIE=0 >> rtc: clear non-PF bits when reinjecting on ack >> >> hw/mc146818rtc.c | 41 +++++++++++++++++++++++------------------ >> 1 files changed, 23 insertions(+), 18 deletions(-) >> > > Ping. Ping^2 Paolo