From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rljfz-00037c-Uy for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:08:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rljft-0003XJ-Ox for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:08:23 -0500 Message-ID: <4F1056ED.908@siemens.com> Date: Fri, 13 Jan 2012 17:08:13 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1325894809-17322-1-git-send-email-andreas.faerber@web.de> <1326424168-15705-1-git-send-email-andreas.faerber@web.de> <1326424168-15705-9-git-send-email-andreas.faerber@web.de> <4F0FF7AD.2080403@siemens.com> <4F10544E.6050501@web.de> In-Reply-To: <4F10544E.6050501@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" , Alexander Graf On 2012-01-13 16:57, Andreas F=C3=A4rber wrote: > Am 13.01.2012 10:21, schrieb Jan Kiszka: >> On 2012-01-13 04:09, Andreas F=C3=A4rber wrote: >>> + isa_bus =3D DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->qde= v, "isa.0")); >>> + >>> + i8259 =3D isa_bus->irqs; >> >> I think this is unneeded. >=20 > The problem here was that isa_get_irq() needs an ISADevice*, not just > the ISABus*, so I had to access ->irqs directly at this point. Which is a hack that should not be merged. >=20 > Some of the later ISA devices are optional, others will be moved to the > pc87312. The i8042 might be an option if we really have to. >=20 >> You only access i8259[8] later on for >> initializing the m48t59. >=20 > And immediately following your quote i8259[9] and i8259[11] for the hos= t > bridge. I was looking at upstream. Which patch is this? >=20 > The alternative would be to access the i8259's IRQs (initialized in the > PCI-ISA bridge needing the PCI host bridge) via a QOM property from > here. Or access the PCI host bridge from the PCI-ISA bridge init. >=20 >> But that one should be creatable as ISA device >> now (m48t59_init_isa), no? Please check. >=20 > Ah, that matches a patch by Herv=C3=A9 confusingly named "fix compilati= on". > Using the ISA version even resolves the m48t59 io_base issue I reported > earlier. I'll send a separate patch and rebase onto that. What about the other IRQs? Can they be associated with ISADevices as well= ? Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux