From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35791)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RlkOH-0005Zp-Tr
	for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:54:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RlkOG-0001Ze-W8
	for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:54:09 -0500
Received: from mail-gx0-f173.google.com ([209.85.161.173]:56948)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RlkOG-0001ZP-QS
	for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:54:08 -0500
Received: by ggnk1 with SMTP id k1so2111556ggn.4
	for <qemu-devel@nongnu.org>; Fri, 13 Jan 2012 08:54:07 -0800 (PST)
Message-ID: <4F1061AB.7040502@codemonkey.ws>
Date: Fri, 13 Jan 2012 10:54:03 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1326448718.git.amit.shah@redhat.com>
In-Reply-To: <cover.1326448718.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/2] qdev: disassociate chardev from
 device on device exit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 01/13/2012 03:59 AM, Amit Shah wrote:
> When the device is going away (e.g., hot-unplug), an associated
> chardev should be freed and made available for use for other devices.
>
> An earlier hack did this for virtio serial ports, do it in a generic
> way and remove the virtio-serial specific hack.

Applied.  Thanks.

Regards,

Anthony Liguori

>
> v2:
>   - actually remove virtconsole_exitfn()
>
> Amit Shah (2):
>    qdev: Add a 'free' method to disassociate chardev from qdev device
>    virtio-console: no need to remove char handlers explicitly
>
>   hw/qdev-properties.c |   11 +++++++++++
>   hw/virtio-console.c  |   17 -----------------
>   2 files changed, 11 insertions(+), 17 deletions(-)
>