From: "Sebastian Herbszt" <herbszt@gmx.de>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-ahci-devel@lists.sourceforge.net,
Sebastian Herbszt <herbszt@gmx.de>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ahci: convert enum to #define
Date: Fri, 14 May 2010 13:05:27 +0200 [thread overview]
Message-ID: <4F10A512AB0744738F0E5E3566C85DAD@FSCPC> (raw)
In-Reply-To: <20100513172742.GC5834@codesourcery.com>
Nathan Froyd wrote:
> On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
>> Convert enum to #define.
>
> This doesn't buy you anything except code churn. It actually makes
> things worse at usual debug levels, too, because the debugger
> understands enums, but not #define.
>
> -Nathan
Alex asked for this in http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg00114.html
Sebastian
prev parent reply other threads:[~2010-05-14 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:19 [Qemu-devel] [PATCH] ahci: convert enum to #define Sebastian Herbszt
2010-05-13 17:27 ` Nathan Froyd
2010-05-14 11:05 ` Sebastian Herbszt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F10A512AB0744738F0E5E3566C85DAD@FSCPC \
--to=herbszt@gmx.de \
--cc=agraf@suse.de \
--cc=froydnj@codesourcery.com \
--cc=qemu-ahci-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).