From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42419 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCsie-0002B7-RU
	for qemu-devel@nongnu.org; Fri, 14 May 2010 07:06:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OCsid-0007UQ-IP
	for qemu-devel@nongnu.org; Fri, 14 May 2010 07:06:16 -0400
Received: from mail.gmx.net ([213.165.64.20]:58220)
	by eggs.gnu.org with smtp (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OCsid-0007Te-6G
	for qemu-devel@nongnu.org; Fri, 14 May 2010 07:06:15 -0400
Message-ID: <4F10A512AB0744738F0E5E3566C85DAD@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <1273771170$123@local> <20100513172742.GC5834@codesourcery.com>
In-Reply-To: <20100513172742.GC5834@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] ahci: convert enum to #define
Date: Fri, 14 May 2010 13:05:27 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-ahci-devel@lists.sourceforge.net, Sebastian Herbszt <herbszt@gmx.de>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Nathan Froyd wrote:
> On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
>> Convert enum to #define.
> 
> This doesn't buy you anything except code churn.  It actually makes
> things worse at usual debug levels, too, because the debugger
> understands enums, but not #define.
> 
> -Nathan

Alex asked for this in http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg00114.html

Sebastian