From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmPMU-0004SZ-LX for qemu-devel@nongnu.org; Sun, 15 Jan 2012 07:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmPMT-0007de-AH for qemu-devel@nongnu.org; Sun, 15 Jan 2012 07:39:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmPMT-0007dY-2b for qemu-devel@nongnu.org; Sun, 15 Jan 2012 07:39:01 -0500 Message-ID: <4F12C8DC.40301@redhat.com> Date: Sun, 15 Jan 2012 14:38:52 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1326453092-4256-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1326453092-4256-3-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1326453092-4256-3-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kernelfans@gmail.com, yamahata@valinux.co.jp On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: > Signed-off-by: Vasilis Liaskovitis > --- > hw/acpi_piix4.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index d5743b6..8bf30dd 100644 > --- a/hw/acpi_piix4.c > +++ b/hw/acpi_piix4.c > @@ -37,6 +37,7 @@ > > #define GPE_BASE 0xafe0 > #define PROC_BASE 0xaf00 > +#define PROC_EJ_BASE 0xaf20 > We're adding stuff to piix4 which was never there. At a minimum this needs to be documented. Also needs to be -M pc-1.1 and later only. -- error compiling committee.c: too many arguments to function