From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmR2z-0003s2-S4 for qemu-devel@nongnu.org; Sun, 15 Jan 2012 09:27:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmR2y-0004fE-PT for qemu-devel@nongnu.org; Sun, 15 Jan 2012 09:27:01 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:48275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmR2y-0004fA-Et for qemu-devel@nongnu.org; Sun, 15 Jan 2012 09:27:00 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate03.web.de (Postfix) with ESMTP id 519CE1AFC909E for ; Sun, 15 Jan 2012 15:26:59 +0100 (CET) Message-ID: <4F12E232.5090809@web.de> Date: Sun, 15 Jan 2012 15:26:58 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1326637051-23920-1-git-send-email-avi@redhat.com> In-Reply-To: <1326637051-23920-1-git-send-email-avi@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig37490A8D32AAB46174D137DE" Subject: Re: [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig37490A8D32AAB46174D137DE Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-01-15 15:17, Avi Kivity wrote: > Otherwise, the dirty log information is lost in the kernel forever. >=20 > Fixes opensuse-12.1 boot screen, which changes the vga windows rapidly.= Confirmed, problems solved here. Thanks, Jan >=20 > Signed-off-by: Avi Kivity > --- >=20 > This patch gives me a deja vu - I'm sure I've fixed exactly the same is= sue > before. >=20 > Please test. >=20 > kvm-all.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >=20 > diff --git a/kvm-all.c b/kvm-all.c > index 3174f42..2cc4562 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection *= section, bool add) > =20 > old =3D *mem; > =20 > + if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) { > + kvm_physical_sync_dirty_bitmap(section); > + } > + > /* unregister the overlapping slot */ > mem->memory_size =3D 0; > err =3D kvm_set_user_memory_region(s, mem); > -- 1.7.7.1 >=20 --------------enig37490A8D32AAB46174D137DE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8S4jIACgkQitSsb3rl5xTt1ACeOYwq35dgB4wHmSrubQHcRkxd y5oAnjQ2m5PakSCPCQAPdDvb8GBOgFIG =hH5X -----END PGP SIGNATURE----- --------------enig37490A8D32AAB46174D137DE--