* [Qemu-devel] [PULL] Fix for kvm dirty logging
@ 2012-01-15 14:36 Avi Kivity
2012-01-15 16:23 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2012-01-15 14:36 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
kvm dirty logging is broken in the presence of memory slots being
removed; this breaks opensuse's boot screen. Following patch fixes:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent
Avi Kivity (1):
kvm: flush the dirty log when unregistering a slot
kvm-all.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 3174f42..2cc4562 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection
*section, bool add)
old = *mem;
+ if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
+ kvm_physical_sync_dirty_bitmap(section);
+ }
+
/* unregister the overlapping slot */
mem->memory_size = 0;
err = kvm_set_user_memory_region(s, mem);
--
error compiling committee.c: too many arguments to function
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PULL] Fix for kvm dirty logging
2012-01-15 14:36 [Qemu-devel] [PULL] Fix for kvm dirty logging Avi Kivity
@ 2012-01-15 16:23 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2012-01-15 16:23 UTC (permalink / raw)
To: Avi Kivity; +Cc: qemu-devel
On 01/15/2012 08:36 AM, Avi Kivity wrote:
> kvm dirty logging is broken in the presence of memory slots being
> removed; this breaks opensuse's boot screen. Following patch fixes:
>
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Avi Kivity (1):
> kvm: flush the dirty log when unregistering a slot
>
> kvm-all.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 3174f42..2cc4562 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection
> *section, bool add)
>
> old = *mem;
>
> + if (mem->flags& KVM_MEM_LOG_DIRTY_PAGES) {
> + kvm_physical_sync_dirty_bitmap(section);
> + }
> +
> /* unregister the overlapping slot */
> mem->memory_size = 0;
> err = kvm_set_user_memory_region(s, mem);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-15 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-15 14:36 [Qemu-devel] [PULL] Fix for kvm dirty logging Avi Kivity
2012-01-15 16:23 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).