From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSgg-0007oC-Og
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:12:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSgf-0003EZ-Ml
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:12:06 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:44471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSgf-0003ET-HO
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:12:05 -0500
Received: by ghbg20 with SMTP id g20so237173ghb.4
	for <qemu-devel@nongnu.org>; Sun, 15 Jan 2012 08:12:05 -0800 (PST)
Message-ID: <4F12FAD2.1080902@codemonkey.ws>
Date: Sun, 15 Jan 2012 10:12:02 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F117F49.1090208@web.de> <4F12E4E4.8030001@codemonkey.ws>
	<4F12E568.2020800@web.de>
In-Reply-To: <4F12E568.2020800@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 01/15/2012 08:40 AM, Jan Kiszka wrote:
> On 2012-01-15 15:38, Anthony Liguori wrote:
>> On 01/14/2012 07:12 AM, Jan Kiszka wrote:
>>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>>
>>> Linking the RTC device state to the PIIX does not belong into the
>>> common path that is shared with the isapc. QEMU crashes otherwise.
>>>
>>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> Does isapc actually work for you?  I tried to write a qemu-test test
>> case (attached below) to help prevent future regressions.  I can
>> reproduce your SEGV but with your patch applied, I get no output (not
>> even the BIOS runs).
>>
>> Here's the command line.  Even a simple 'qemu-system-x86_64 -M isapc'
>> reproduces it:
>>
>> /home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel
>> bin/vmlinuz-3.0 -initrd .tmp-3510/initramfs-3510.img.gz -append
>> console=ttyS0 seed=24689 -M isapc -pidfile .tmp-3510/pidfile-3510.pid
>> -qmp unix:.tmp-3510/qmpsock-3510.sock,server,nowait
>
> You need to update seabios to the last release at least (should have
> been done much earlier), and it only works for KVM (as that mode ignores
> some ROM write protections where seabios obviously has some troubles with).

Can you send a pull request?  SeaBIOS no longer builds on my laptop...

Regards,

Anthony Liguori

>
> Jan
>