From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmSoU-0002QI-Lq for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:20:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmSoT-0004Ps-Gv for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:20:10 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:40926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmSoT-0004Pk-Cw for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:20:09 -0500 Received: by ggnk1 with SMTP id k1so2877187ggn.4 for ; Sun, 15 Jan 2012 08:20:08 -0800 (PST) Message-ID: <4F12FCB5.3000200@codemonkey.ws> Date: Sun, 15 Jan 2012 10:20:05 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4F117F49.1090208@web.de> <4F12E4E4.8030001@codemonkey.ws> <4F12E568.2020800@web.de> <4F12FAD2.1080902@codemonkey.ws> <4F12FBC2.8070706@web.de> In-Reply-To: <4F12FBC2.8070706@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 01/15/2012 10:16 AM, Jan Kiszka wrote: > On 2012-01-15 17:12, Anthony Liguori wrote: >> On 01/15/2012 08:40 AM, Jan Kiszka wrote: >>> On 2012-01-15 15:38, Anthony Liguori wrote: >>>> On 01/14/2012 07:12 AM, Jan Kiszka wrote: >>>>> From: Jan Kiszka >>>>> >>>>> Linking the RTC device state to the PIIX does not belong into the >>>>> common path that is shared with the isapc. QEMU crashes otherwise. >>>>> >>>>> Signed-off-by: Jan Kiszka >>>> >>>> Does isapc actually work for you? I tried to write a qemu-test test >>>> case (attached below) to help prevent future regressions. I can >>>> reproduce your SEGV but with your patch applied, I get no output (not >>>> even the BIOS runs). >>>> >>>> Here's the command line. Even a simple 'qemu-system-x86_64 -M isapc' >>>> reproduces it: >>>> >>>> /home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel >>>> bin/vmlinuz-3.0 -initrd .tmp-3510/initramfs-3510.img.gz -append >>>> console=ttyS0 seed=24689 -M isapc -pidfile .tmp-3510/pidfile-3510.pid >>>> -qmp unix:.tmp-3510/qmpsock-3510.sock,server,nowait >>> >>> You need to update seabios to the last release at least (should have >>> been done much earlier), and it only works for KVM (as that mode ignores >>> some ROM write protections where seabios obviously has some troubles >>> with). >> >> Can you send a pull request? SeaBIOS no longer builds on my laptop... > > Will do. Last release of current master preferred? Yes. Regards, Anthony Liguori > > Jan >