From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSre-0003Lj-Io
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:23:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSrd-0004ew-F7
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:23:26 -0500
Received: from mail-gx0-f173.google.com ([209.85.161.173]:33824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmSrd-0004es-9K
	for qemu-devel@nongnu.org; Sun, 15 Jan 2012 11:23:25 -0500
Received: by ggnk1 with SMTP id k1so2877878ggn.4
	for <qemu-devel@nongnu.org>; Sun, 15 Jan 2012 08:23:25 -0800 (PST)
Message-ID: <4F12FD7A.1010301@codemonkey.ws>
Date: Sun, 15 Jan 2012 10:23:22 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F12E473.9080700@redhat.com>
In-Reply-To: <4F12E473.9080700@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] Fix for kvm dirty logging
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 01/15/2012 08:36 AM, Avi Kivity wrote:
> kvm dirty logging is broken in the presence of memory slots being
> removed; this breaks opensuse's boot screen.  Following patch fixes:
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> Avi Kivity (1):
>        kvm: flush the dirty log when unregistering a slot
>
>   kvm-all.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 3174f42..2cc4562 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection
> *section, bool add)
>
>           old = *mem;
>
> +        if (mem->flags&  KVM_MEM_LOG_DIRTY_PAGES) {
> +            kvm_physical_sync_dirty_bitmap(section);
> +        }
> +
>           /* unregister the overlapping slot */
>           mem->memory_size = 0;
>           err = kvm_set_user_memory_region(s, mem);
>