From: Hannes Reinecke <hare@suse.de>
To: Avi Kivity <avi@redhat.com>
Cc: "Alexander Graf" <agraf@suse.de>,
"Andreas Färber" <afaerber@suse.de>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
Date: Mon, 16 Jan 2012 08:18:45 +0100 [thread overview]
Message-ID: <4F13CF55.9040008@suse.de> (raw)
In-Reply-To: <4F129A9C.9030903@redhat.com>
On 01/15/2012 10:21 AM, Avi Kivity wrote:
> On 01/13/2012 06:54 PM, Andreas Färber wrote:
>>> +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd)
>>> +{
>>> + int i, is_write = megasas_frame_is_write(cmd);
>>> +
>>> + for (i = 0; i < cmd->iov_cnt; i++) {
>>> + cpu_physical_memory_unmap(cmd->iov[i].iov_base, cmd->iov[i].iov_len,
>>> + is_write, cmd->iov[i].iov_len);
>>
>> Not sure, but cpu_physical_memory_* sounds old-fashioned. Might need an
>> update to MemoryRegion?
>
> These APIs have not been updated (yet?).
>
That's what I thought.
Plus even virtio is using it, so I'd be very much interested in the
argument why megasas can't use it ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2012-01-16 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:19 [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-01-13 16:14 ` Anthony Liguori
2012-01-13 16:35 ` Paolo Bonzini
2012-01-16 9:18 ` Hannes Reinecke
2012-01-16 13:38 ` Anthony Liguori
2012-01-13 16:54 ` Andreas Färber
2012-01-15 9:21 ` Avi Kivity
2012-01-16 7:18 ` Hannes Reinecke [this message]
2012-01-16 13:39 ` Anthony Liguori
2012-01-16 13:59 ` Hannes Reinecke
2012-01-16 14:05 ` Alexander Graf
2012-01-16 14:50 ` Avi Kivity
2012-01-16 15:35 ` Alexander Graf
2012-01-16 15:38 ` Avi Kivity
2012-01-16 15:39 ` Alexander Graf
2012-01-16 15:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13CF55.9040008@suse.de \
--to=hare@suse.de \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).