From: Kevin Wolf <kwolf@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command
Date: Mon, 16 Jan 2012 10:33:49 +0100 [thread overview]
Message-ID: <4F13EEFD.2070403@redhat.com> (raw)
In-Reply-To: <1326613915-3282-3-git-send-email-hpoussin@reactos.org>
Am 15.01.2012 08:51, schrieb Hervé Poussineau:
> This bit must be active while a command is currently executed.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
I believe this could use some more cleanup. The flag is set and reset
multiple times in places that aren't quite obvious. Not saying it should
be done in this patch, but maybe in a follow-up series.
Kevin
next prev parent reply other threads:[~2012-01-16 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 7:51 [Qemu-devel] [PATCH v2 00/10] Misc fixes for floppy emulation Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 01/10] fdc: take side count into account Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command Hervé Poussineau
2012-01-16 9:33 ` Kevin Wolf [this message]
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 03/10] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0 Hervé Poussineau
2012-01-16 9:54 ` Kevin Wolf
2012-01-23 7:58 ` Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 05/10] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 06/10] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types Hervé Poussineau
2012-01-16 10:18 ` Kevin Wolf
2012-01-21 19:02 ` Blue Swirl
2012-01-23 8:51 ` Kevin Wolf
2012-01-23 16:56 ` Blue Swirl
2012-01-27 8:33 ` Markus Armbruster
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 08/10] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 09/10] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-01-16 10:32 ` Kevin Wolf
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 10/10] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13EEFD.2070403@redhat.com \
--to=kwolf@redhat.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).