From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmitf-0007Sb-Px for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:30:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmitZ-0005Ak-UB for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:30:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmitZ-0005AT-MU for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:30:29 -0500 Message-ID: <4F13EEFD.2070403@redhat.com> Date: Mon, 16 Jan 2012 10:33:49 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1326613915-3282-1-git-send-email-hpoussin@reactos.org> <1326613915-3282-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1326613915-3282-3-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 15.01.2012 08:51, schrieb Herv=C3=A9 Poussineau: > This bit must be active while a command is currently executed. >=20 > Signed-off-by: Herv=C3=A9 Poussineau I believe this could use some more cleanup. The flag is set and reset multiple times in places that aren't quite obvious. Not saying it should be done in this patch, but maybe in a follow-up series. Kevin