From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmjDc-0004x9-3W for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:51:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmjDW-0000dC-59 for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:51:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmjDV-0000cy-Th for qemu-devel@nongnu.org; Mon, 16 Jan 2012 04:51:06 -0500 Message-ID: <4F13F3D3.9010200@redhat.com> Date: Mon, 16 Jan 2012 10:54:27 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1326613915-3282-1-git-send-email-hpoussin@reactos.org> <1326613915-3282-5-git-send-email-hpoussin@reactos.org> In-Reply-To: <1326613915-3282-5-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 15.01.2012 08:51, schrieb Herv=C3=A9 Poussineau: > Stepping 1 (S82078B) is not fully i82078 compatible, so better stick to= initial revision >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/fdc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/fdc.c b/hw/fdc.c > index bedaeca..0e167f8 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -1385,7 +1385,7 @@ static void fdctrl_handle_version(FDCtrl *fdctrl,= int direction) > =20 > static void fdctrl_handle_partid(FDCtrl *fdctrl, int direction) > { > - fdctrl->fifo[0] =3D 0x41; /* Stepping 1 */ > + fdctrl->fifo[0] =3D 0x01; /* Stepping 0 */ > fdctrl_set_fifo(fdctrl, 1, 0); > } > =20 Hm, this is the kind of change that I'm hesitant to make because I don't understand the implications. Can you give some more details what is fixed by this and why you think it's harmless for currently working OSes? My spec says this: 6 3 14 PART ID COMMAND This command can be used to identify the floppy disk controller as an enhanced controller The first stepping of the 82078 (all 44 pin versions) will yield 0x41 in the result phase of this command Any future enhancements on these parts will be denoted by the 5 LSBs (0x01 to 0x1F) It doesn't even define what 0x01 would mean. Kevin