From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmjaa-0000gg-GI for qemu-devel@nongnu.org; Mon, 16 Jan 2012 05:15:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmjaU-0004YM-ET for qemu-devel@nongnu.org; Mon, 16 Jan 2012 05:14:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmjaU-0004YF-6Z for qemu-devel@nongnu.org; Mon, 16 Jan 2012 05:14:50 -0500 Message-ID: <4F13F964.1020609@redhat.com> Date: Mon, 16 Jan 2012 11:18:12 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1326613915-3282-1-git-send-email-hpoussin@reactos.org> <1326613915-3282-8-git-send-email-hpoussin@reactos.org> In-Reply-To: <1326613915-3282-8-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 15.01.2012 08:51, schrieb Herv=C3=A9 Poussineau: > Floppies must be read at a specific transfer rate, depending of its own= format. > Update floppy description table to include required transfer rate. >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > block.c | 74 ++++++++++++++++++++++++++++++++----------------------= ------- > block.h | 10 +++++++- > hw/fdc.c | 3 +- > hw/pc.c | 3 +- Meh. Having any floppy-specific logic in the block layer is wrong. We need to finally get this moved into fdc.c. Kevin