From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RmlXl-0000bP-1q
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:20:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RmlXh-0000WH-0y
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:20:09 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48226 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RmlXg-0000Up-Oe
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:20:04 -0500
Message-ID: <4F141583.40706@suse.de>
Date: Mon, 16 Jan 2012 13:18:11 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1326674823-13069-1-git-send-email-afaerber@suse.de>
	<1326674823-13069-2-git-send-email-afaerber@suse.de>
	<CAFEAcA9npZFvAPbvLDin75Jj=iiOZNgk2xZepoisntZh_BDKRQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9npZFvAPbvLDin75Jj=iiOZNgk2xZepoisntZh_BDKRQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and
	uint32_t
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Michael Walle <michael@walle.cc>, qemu-devel@nongnu.org

Am 16.01.2012 12:27, schrieb Peter Maydell:
> On 16 January 2012 00:46, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> diff --git a/hw/milkymist-vgafb_template.h b/hw/milkymist-vgafb_templa=
te.h
>> index 69af9ef..544b55e 100644
>> --- a/hw/milkymist-vgafb_template.h
>> +++ b/hw/milkymist-vgafb_template.h
>> @@ -39,7 +39,7 @@
>>  #elif BITS =3D=3D 24
>>  #define COPY_PIXEL(to, r, g, b)                    \
>>     do {                                           \
>> -        uint32 tmp =3D rgb_to_pixel24(r, g, b);      \
>> +        uint32_t tmp =3D rgb_to_pixel24(r, g, b);      \
>>         *(to++) =3D         tmp & 0xff;              \
>>         *(to++) =3D  (tmp >> 8) & 0xff;              \
>>         *(to++) =3D (tmp >> 16) & 0xff;              \
>=20
> This change breaks the otherwise consistent alignment of the '\'
> characters in column 51...

Thanks, will fix!

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg