Re: [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h

["Andreas Färber" <afaerber@suse.de>]

Am 16.01.2012 13:21, schrieb Peter Maydell:
> On 16 January 2012 12:13, Andreas Färber <afaerber@suse.de> wrote:
>> Am 16.01.2012 12:38, schrieb Peter Maydell:
>>> On 16 January 2012 00:46, Andreas Färber <afaerber@suse.de> wrote:
>>>> +#if defined(CONFIG_SOLARIS) && CONFIG_SOLARIS_VERSION < 10
>>>> +/* uint_fast8_t and uint_fast16_t not in <sys/int_types.h> */
>>>> +typedef unsigned char           uint_fast8_t;
>>>> +typedef unsigned int            uint_fast16_t;
>>>> +#endif
>>>
>>> If you make the comment say
>>> /* uint_fast*_t and int_fast*_t not in <sys/int_types.h> */
>>>
>>> then it won't become out of date when your later patches add
>>> the other types to this section.
>>
>> I have no clue if that is the case, I just moved it and fixed the
>> comment style. But sure, I can change the comment itself as well.
> 
> Well, your later patches add more typedefs here, right? So we need
> to know: either old Solaris doesn't have any of these types and we
> must typedef them all (and the comment should match that), or it
> is only missing the two currently noted here, in which case we don't
> need to and should not add further typedefs. What we don't want is
> to have a comment and code which disagree...

I'm hoping Ben can clarify. Fabrice attributed the Solaris/sparc support
to him.

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg