From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmmmZ-0006J6-Qy
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:39:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmmmT-0005dF-Tv
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:39:31 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:58390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RmmmT-0005cu-Qy
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:39:25 -0500
Received: by iaeo4 with SMTP id o4so8665886iae.4
	for <qemu-devel@nongnu.org>; Mon, 16 Jan 2012 05:39:25 -0800 (PST)
Message-ID: <4F142889.2070109@codemonkey.ws>
Date: Mon, 16 Jan 2012 07:39:21 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1326453552-17189-1-git-send-email-hare@suse.de>
	<4F1061CE.50005@suse.de>
In-Reply-To: <4F1061CE.50005@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Hannes Reinecke <hare@suse.de>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Avi Kivity <avi@redhat.com>

On 01/13/2012 10:54 AM, Andreas Färber wrote:
> Am 13.01.2012 12:19, schrieb Hannes Reinecke:
>> +    if (desc) {
>> +        trace_megasas_readl_reg("mmio", desc, retval);
>> +    } else {
>> +        trace_megasas_readl("mmio", addr, retval);
>> +    }
>
> Drop _reg version?
>
> Didn't review the SCSI bits. Patch is pretty large, too. ;)

I have the same thought but it looks to be large because of the header and 
tracing file.  I didn't see an obvious place to break it up.

Although Hannes, if there is a way to break it up, that would certainly help review.

Regards,

Anthony Liguori

>
> Regards,
> Andreas
>