From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1Rmn61-00010Y-Sp
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:59:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1Rmn5x-0000zr-UN
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:59:37 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53408 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1Rmn5x-0000zk-OT
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 08:59:33 -0500
Message-ID: <4F142D44.20802@suse.de>
Date: Mon, 16 Jan 2012 14:59:32 +0100
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
References: <1326453552-17189-1-git-send-email-hare@suse.de>
	<4F1061CE.50005@suse.de> <4F142889.2070109@codemonkey.ws>
In-Reply-To: <4F142889.2070109@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Avi Kivity <avi@redhat.com>

On 01/16/2012 02:39 PM, Anthony Liguori wrote:
> On 01/13/2012 10:54 AM, Andreas F=E4rber wrote:
>> Am 13.01.2012 12:19, schrieb Hannes Reinecke:
>>> +    if (desc) {
>>> +        trace_megasas_readl_reg("mmio", desc, retval);
>>> +    } else {
>>> +        trace_megasas_readl("mmio", addr, retval);
>>> +    }
>>
>> Drop _reg version?
>>
>> Didn't review the SCSI bits. Patch is pretty large, too. ;)
>=20
> I have the same thought but it looks to be large because of the
> header and tracing file.  I didn't see an obvious place to break it up.
>=20
> Although Hannes, if there is a way to break it up, that would
> certainly help review.
>=20
Hmm. Yes, I could try to split it up by removing the trace hooks and
add them with a later patch.

But the emulation itself would be pretty pointless to split up ...

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)