From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RmoCx-0006I8-AG
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 10:10:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RmoCr-0006a0-PU
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 10:10:51 -0500
Message-ID: <4F143D83.3050502@web.de>
Date: Mon, 16 Jan 2012 16:08:51 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1325894809-17322-1-git-send-email-andreas.faerber@web.de>
	<1326424168-15705-1-git-send-email-andreas.faerber@web.de>
	<1326424168-15705-4-git-send-email-andreas.faerber@web.de>
	<4F129A1A.9070709@redhat.com>
In-Reply-To: <4F129A1A.9070709@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 3/8] prep_pci: Update I/O to
	MemoryRegion ops
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@gmail.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Am 15.01.2012 10:19, schrieb Avi Kivity:
> On 01/13/2012 05:09 AM, Andreas Färber wrote:
>> Convert to new-style read/write callbacks.
>>
>>  
>> -static uint32_t PPC_PCIIO_readl (void *opaque, target_phys_addr_t addr)
>> +static uint64_t ppc_pci_io_read(void *opaque, target_phys_addr_t addr,
>> +                                unsigned int size)
>>  {
>>      PREPPCIState *s = opaque;
>> -    uint32_t val;
>> -    val = pci_data_read(s->bus, PPC_PCIIO_config(addr), 4);
>> -    return val;
>> +    switch (size) {
>> +    case 1:
>> +    case 2:
>> +    case 4:
>> +        return pci_data_read(s->bus, PPC_PCIIO_config(addr), size);
>> +    default:
>> +        abort();
>> +    }
>>  }
> 
> Huh? just call pci_data_read() unconditionally.

Just so that I understand, is that because PReP is 32-bit ppc? In the
above mechanical conversion, size 8 would abort.

BTW did we agree on an indentation style for switch?

Andreas