From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
"Hannes Reinecke" <hare@suse.de>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
Date: Mon, 16 Jan 2012 17:38:09 +0200 [thread overview]
Message-ID: <4F144461.7000803@redhat.com> (raw)
In-Reply-To: <E282745F-7FFE-4738-A154-8C547A676032@suse.de>
On 01/16/2012 05:35 PM, Alexander Graf wrote:
> On 16.01.2012, at 15:50, Avi Kivity wrote:
>
> > On 01/16/2012 04:05 PM, Alexander Graf wrote:
> >>>
> >>> But the emulation itself would be pretty pointless to split up ...
> >>
> >> You could add the header in a separate first patch :)
> >>
> >>
> >
> > That makes reviewing harder, not easier.
>
> Oh, really?
That's my opinion. The headers and the code don't make sense without
each other.
> It's basically just a copy from Linux, so it shouldn't need all the review the actual emulation code needs, no?
So just skip it. Dividing things into patches helps when you
disentangle multiple logical changes. If the multiple changes just
follow each other in the diff, splitting doesn't change anything.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-01-16 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:19 [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-01-13 16:14 ` Anthony Liguori
2012-01-13 16:35 ` Paolo Bonzini
2012-01-16 9:18 ` Hannes Reinecke
2012-01-16 13:38 ` Anthony Liguori
2012-01-13 16:54 ` Andreas Färber
2012-01-15 9:21 ` Avi Kivity
2012-01-16 7:18 ` Hannes Reinecke
2012-01-16 13:39 ` Anthony Liguori
2012-01-16 13:59 ` Hannes Reinecke
2012-01-16 14:05 ` Alexander Graf
2012-01-16 14:50 ` Avi Kivity
2012-01-16 15:35 ` Alexander Graf
2012-01-16 15:38 ` Avi Kivity [this message]
2012-01-16 15:39 ` Alexander Graf
2012-01-16 15:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F144461.7000803@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).