From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44772)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rmodk-0000BW-7b
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 10:38:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rmodj-0005ft-BQ
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 10:38:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rmodi-0005fY-W3
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 10:38:31 -0500
Message-ID: <4F144461.7000803@redhat.com>
Date: Mon, 16 Jan 2012 17:38:09 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1326453552-17189-1-git-send-email-hare@suse.de>
	<4F1061CE.50005@suse.de> <4F142889.2070109@codemonkey.ws>
	<4F142D44.20802@suse.de>
	<956822AD-1B36-4F92-952A-F2D3FD7A864C@suse.de>
	<4F143930.3010209@redhat.com>
	<E282745F-7FFE-4738-A154-8C547A676032@suse.de>
In-Reply-To: <E282745F-7FFE-4738-A154-8C547A676032@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Hannes Reinecke <hare@suse.de>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 01/16/2012 05:35 PM, Alexander Graf wrote:
> On 16.01.2012, at 15:50, Avi Kivity wrote:
>
> > On 01/16/2012 04:05 PM, Alexander Graf wrote:
> >>> 
> >>> But the emulation itself would be pretty pointless to split up ...
> >> 
> >> You could add the header in a separate first patch :)
> >> 
> >> 
> > 
> > That makes reviewing harder, not easier.
>
> Oh, really? 

That's my opinion.  The headers and the code don't make sense without
each other.

> It's basically just a copy from Linux, so it shouldn't need all the review the actual emulation code needs, no?

So just skip it.  Dividing things into patches helps when you
disentangle multiple logical changes.  If the multiple changes just
follow each other in the diff, splitting doesn't change anything.

-- 
error compiling committee.c: too many arguments to function