From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn9Cg-0003bN-61 for qemu-devel@nongnu.org; Tue, 17 Jan 2012 08:36:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn9Cb-0003Ul-PH for qemu-devel@nongnu.org; Tue, 17 Jan 2012 08:35:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn9Cb-0003UZ-Gk for qemu-devel@nongnu.org; Tue, 17 Jan 2012 08:35:53 -0500 Message-ID: <4F1579E8.5000007@redhat.com> Date: Tue, 17 Jan 2012 14:38:48 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1326460457-19446-1-git-send-email-stefanha@linux.vnet.ibm.com> <1326460457-19446-2-git-send-email-stefanha@linux.vnet.ibm.com> <4F156FA0.9010300@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 01/15] coroutine: add co_sleep_ns() coroutine sleep function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Luiz Capitulino , Marcelo Tosatti , Stefan Hajnoczi , qemu-devel@nongnu.org Am 17.01.2012 14:31, schrieb Stefan Hajnoczi: > On Tue, Jan 17, 2012 at 12:54 PM, Kevin Wolf wrote: >> Am 13.01.2012 14:14, schrieb Stefan Hajnoczi: >>> Signed-off-by: Stefan Hajnoczi >>> --- >>> Makefile.objs | 1 + >>> qemu-coroutine-sleep.c | 38 ++++++++++++++++++++++++++++++++++++++ >>> qemu-coroutine.h | 9 +++++++++ >>> 3 files changed, 48 insertions(+), 0 deletions(-) >>> create mode 100644 qemu-coroutine-sleep.c >>> >>> diff --git a/Makefile.objs b/Makefile.objs >>> index 4f6d26c..f4f52e0 100644 >>> --- a/Makefile.objs >>> +++ b/Makefile.objs >>> @@ -13,6 +13,7 @@ oslib-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o >>> ####################################################################### >>> # coroutines >>> coroutine-obj-y = qemu-coroutine.o qemu-coroutine-lock.o qemu-coroutine-io.o >>> +coroutine-obj-y += qemu-coroutine-sleep.o >>> ifeq ($(CONFIG_UCONTEXT_COROUTINE),y) >>> coroutine-obj-$(CONFIG_POSIX) += coroutine-ucontext.o >>> else >>> diff --git a/qemu-coroutine-sleep.c b/qemu-coroutine-sleep.c >>> new file mode 100644 >>> index 0000000..fd65274 >>> --- /dev/null >>> +++ b/qemu-coroutine-sleep.c >>> @@ -0,0 +1,38 @@ >>> +/* >>> + * QEMU coroutine sleep >>> + * >>> + * Copyright IBM, Corp. 2011 >>> + * >>> + * Authors: >>> + * Stefan Hajnoczi >>> + * >>> + * This work is licensed under the terms of the GNU LGPL, version 2 or later. >>> + * See the COPYING.LIB file in the top-level directory. >>> + * >>> + */ >>> + >>> +#include "qemu-coroutine.h" >>> +#include "qemu-timer.h" >>> + >>> +typedef struct CoSleepCB { >>> + QEMUTimer *ts; >>> + Coroutine *co; >>> +} CoSleepCB; >>> + >>> +static void co_sleep_cb(void *opaque) >>> +{ >>> + CoSleepCB *sleep_cb = opaque; >>> + >>> + qemu_free_timer(sleep_cb->ts); >> >> I think you need to call qemu_del_timer() first. > > I think we're okay with just qemu_free_timer(). qemu_run_timers() > removes the timer from the active_timers list before invoking its > callback. qemu_del_timer() is not needed because it just searches the > active_timers list and removes the timer, if found. We're no longer > on the active_timers list at the point when co_sleep_cb() is called, > so there's no need. Yes, seems you're right. qemu_del_timer() isn't a good name... Kevin