From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnDY6-0000yJ-Pr for qemu-devel@nongnu.org; Tue, 17 Jan 2012 13:14:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnDY0-000429-JU for qemu-devel@nongnu.org; Tue, 17 Jan 2012 13:14:22 -0500 Received: from thoth.sbs.de ([192.35.17.2]:29469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnDY0-00041h-Az for qemu-devel@nongnu.org; Tue, 17 Jan 2012 13:14:16 -0500 Message-ID: <4F15BA62.3010609@siemens.com> Date: Tue, 17 Jan 2012 19:13:54 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1326823633-11524-1-git-send-email-emunson@mgebm.net> In-Reply-To: <1326823633-11524-1-git-send-email-emunson@mgebm.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V6] Guest stop notification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric B Munson Cc: "ryanh@linux.vnet.ibm.com" , "aliguori@us.ibm.com" , "kvm@vger.kernel.org" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity On 2012-01-17 19:07, Eric B Munson wrote: > Often when a guest is stopped from the qemu console, it will report spurious > soft lockup warnings on resume. There are kernel patches being discussed that > will give the host the ability to tell the guest that it is being stopped and > should ignore the soft lockup warning that generates. This patch uses the qemu > Notifier system to tell the guest it is about to be stopped. > > Signed-off-by: Eric B Munson > > Cc: Avi Kivity > Cc: Marcelo Tosatti > Cc: Jan Kiszka > Cc: ryanh@linux.vnet.ibm.com > Cc: aliguori@us.ibm.com > Cc: kvm@vger.kernel.org > --- > Changes from V5: > KVM_GUEST_PAUSED is now a per vm ioctl instead of per vcpu > > Changes from V4: > Test if the guest paused capability is available before use > > Changes from V3: > Collapse new state change notification function into existsing function. > Correct whitespace issues > Change ioctl name to KVMCLOCK_GUEST_PAUSED > Use for loop to iterate vpcu's > > Changes from V2: > Move ioctl into hw/kvmclock.c so as other arches can use it as it is > implemented > > Changes from V1: > Remove unnecessary encapsulating function > hw/kvmclock.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/hw/kvmclock.c b/hw/kvmclock.c > index 3b9fb20..a30504c 100644 > --- a/hw/kvmclock.c > +++ b/hw/kvmclock.c > @@ -18,6 +18,7 @@ > #include "sysbus.h" > #include "kvm.h" > #include "kvmclock.h" > +#include "cpu-all.h" Still needed? > > #include > #include > @@ -64,10 +65,21 @@ static int kvmclock_post_load(void *opaque, int version_id) > static void kvmclock_vm_state_change(void *opaque, int running, > RunState state) > { > + int ret; > KVMClockState *s = opaque; > + int cap_guest_paused = kvm_check_extension(kvm_state, KVM_CAP_GUEST_PAUSED); > > if (running) { > s->clock_valid = false; > + > + if (!cap_guest_paused) { > + return; > + } > + > + ret = kvm_vm_ioctl(kvm_state, KVMCLOCK_GUEST_PAUSED, 0); > + if (ret) { > + fprintf(stderr, "kvmclock_vm_state_change: %s\n", strerror(-ret)); > + } > } > } > Looks good otherwise. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux