From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49322)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1RnWbn-0000FV-If
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 09:35:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1RnWbi-0006za-KS
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 09:35:27 -0500
Received: from smtp131.dfw.emailsrvr.com ([67.192.241.131]:55946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.langsdorf@calxeda.com>) id 1RnWbi-0006zS-Fp
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 09:35:22 -0500
Message-ID: <4F16D8AA.6020307@calxeda.com>
Date: Wed, 18 Jan 2012 08:35:22 -0600
From: Mark Langsdorf <mark.langsdorf@calxeda.com>
MIME-Version: 1.0
References: <1326213943-878-1-git-send-email-mark.langsdorf@calxeda.com>
	<1326808231-32545-1-git-send-email-mark.langsdorf@calxeda.com>
	<1326808231-32545-5-git-send-email-mark.langsdorf@calxeda.com>
	<CAFEAcA9D3DSTet3Py_4rPc1mGiS8NQNwJ7tnZF2UT1VWiSW3qQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9D3DSTet3Py_4rPc1mGiS8NQNwJ7tnZF2UT1VWiSW3qQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "i.mitsyanko@gmail.com" <i.mitsyanko@gmail.com>, "edgar.iglesias@gmail.com" <edgar.iglesias@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Rob Herring <rob.herring@calxeda.com>, "afaerber@suse.de" <afaerber@suse.de>

On 01/17/2012 09:13 AM, Peter Maydell wrote:
> On 17 January 2012 13:50, Mark Langsdorf <mark.langsdorf@calxeda.com> wrote:
>> +    highbank_binfo.ram_size = ram_size;
>> +    highbank_binfo.kernel_filename = kernel_filename;
>> +    highbank_binfo.kernel_cmdline = kernel_cmdline;
>> +    highbank_binfo.initrd_filename = initrd_filename;
>> +    highbank_binfo.board_id = -1; /* provided by deviceTree */
>> +    highbank_binfo.nb_cpus = smp_cpus;
>> +    highbank_binfo.loader_start = 0;
>> +    highbank_binfo.smp_loader_start = SMP_BOOT_ADDR;
>> +    arm_load_kernel(env, &highbank_binfo);
> 
> Unfortunately for you Evgeny's patch to arm_boot.c has been
> committed to master (commit 078758d0) which means you need
> to update this to specify a value for highbank_binfo.smp_bootreg_addr.
> 
> Incidentally I'm surprised this worked for you at all -- before
> Evgeny's patch the secondary bootloader code in arm_boot.c would
> have been polling 0x10000030, which the highbank kernel code
> doesn't ever change, so I don't see how you got the secondary
> cores into the kernel when using -kernel...

I think I was undertesting.

I can set the smp_loader code so that I can boot 2 cpus
and verify their existence in /proc/cpuinfo, but I can't
get 3 cpus to boot at all, no matter how I hack the existing
arm_boot code.

Is there a good example of how to write secondary smp boot
code other than arm_boot.c? Should I just expect to pull
most of arm_boot.c into highbank and adjust from there? I
don't want to duplicate code like that, but I need more
flexibility than I can easily add to arm_boot.c.

--Mark Langsdorf
Calxeda, Inc.