* [Qemu-devel] direct usage of rt_clock instead of rtc_clock
@ 2012-01-18 18:04 Paolo Bonzini
2012-01-18 19:02 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2012-01-18 18:04 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, Andrzej Zaborowski
Hi Peter and Andrzej,
the following four files in hw/ are using rt_clock directly
omap1.c
pxa2xx.c
strongarm.c
twl92230.c
instead of rtc_clock. This means that they're not completely
deterministic when using -icount or in the future qtest. A simple
search-and-replace would be okay I think. However they could also use a
notifier to update the timers whenever the rtc_clock jumped backwards
(see commit 17604da). If you are going to add the notifier I'll happily
leave the work to you; otherwise I'll post the search-and-replace patch.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] direct usage of rt_clock instead of rtc_clock
2012-01-18 18:04 [Qemu-devel] direct usage of rt_clock instead of rtc_clock Paolo Bonzini
@ 2012-01-18 19:02 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2012-01-18 19:02 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Andrzej Zaborowski, qemu-devel
On 18 January 2012 18:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
> the following four files in hw/ are using rt_clock directly
>
> omap1.c
> pxa2xx.c
> strongarm.c
> twl92230.c
>
> instead of rtc_clock. This means that they're not completely deterministic
> when using -icount or in the future qtest. A simple search-and-replace
> would be okay I think. However they could also use a notifier to update the
> timers whenever the rtc_clock jumped backwards (see commit 17604da). If you
> are going to add the notifier I'll happily leave the work to you; otherwise
> I'll post the search-and-replace patch.
I have no strong interest in any of these platforms -- if the simple
search-n-replace you propose works OK and has no particular disadvantages
over the code as it stands that's fine with me.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-18 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 18:04 [Qemu-devel] direct usage of rt_clock instead of rtc_clock Paolo Bonzini
2012-01-18 19:02 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).