From: Kevin Wolf <kwolf@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI
Date: Fri, 20 Jan 2012 10:34:17 +0100 [thread overview]
Message-ID: <4F193519.9020605@redhat.com> (raw)
In-Reply-To: <CAN05THTOz8CDoS_VKaSYAZTCX-fSj5t2=8iHAmFzU9AUxSodVA@mail.gmail.com>
Am 20.01.2012 09:58, schrieb ronnie sahlberg:
> On Thu, Jan 19, 2012 at 11:17 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 18.12.2011 05:48, schrieb Ronnie Sahlberg:
>>> This patch adds configuration variables for iSCSI to set
>>> initiator-name to use when logging in to the target,
>>> which type of header-digest to negotiate with the target
>>> and username and password for CHAP authentication.
>>>
>>> This allows specifying a initiator-name either from the command line
>>> -iscsi initiator-name=iqn.2004-01.com.example:test
>>> or from a configuration file included with -readconfig
>>> [iscsi]
>>> initiator-name = iqn.2004-01.com.example:test
>>> header-digest = CRC32C|CRC32C-NONE|NONE-CRC32C|NONE
>>> user = CHAP username
>>> password = CHAP password
>>>
>>> The patch also updates the manpage and qemu-doc
>>>
>>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>
>> So these options are global? What if I wanted to use two different
>> setups for two different images?
>>
>
>
> Good point.
> I will rework the patch so that it first checks for
> [iscsi "iqn.target.name"]
> and if that is not found it falls-back to just checking for [iscsi]
>
> That would allow to have one "catch all" section for all targets, but
> also the possibility to override and use different settings on a
> per-target basis.
>
> I will post an updated patch in a day or two.
Thanks, this sounds like a good solution.
Kevin
next prev parent reply other threads:[~2012-01-20 9:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 4:48 [Qemu-devel] Patch to add iSCSI configuration optionsi. Version 2 Ronnie Sahlberg
2011-12-18 4:48 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2011-12-18 13:48 ` Paolo Bonzini
2011-12-22 20:51 ` ronnie sahlberg
2011-12-23 9:08 ` Paolo Bonzini
2011-12-23 9:54 ` ronnie sahlberg
2012-01-03 10:12 ` Daniel P. Berrange
2012-01-19 12:17 ` Kevin Wolf
2012-01-20 8:58 ` ronnie sahlberg
2012-01-20 9:34 ` Kevin Wolf [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 22:39 [Qemu-devel] [PATCH 0/0] Add " Ronnie Sahlberg
2012-01-25 22:39 ` [Qemu-devel] [PATCH] iSCSI: add " Ronnie Sahlberg
2012-01-25 22:53 ` Eric Blake
2012-01-26 10:58 ` Kevin Wolf
2012-01-21 10:03 [Qemu-devel] [PATCH] Add configuration variables for iscsi Ronnie Sahlberg
2012-01-21 10:03 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2012-01-23 18:07 ` Eric Blake
2012-01-25 6:47 ` ronnie sahlberg
2012-01-25 15:57 ` Eric Blake
2012-01-25 22:17 ` ronnie sahlberg
2012-01-26 9:08 ` Kevin Wolf
2012-01-26 9:18 ` ronnie sahlberg
2012-01-26 9:27 ` Kevin Wolf
2012-01-26 9:54 ` ronnie sahlberg
2012-01-26 14:55 ` Michael Tokarev
2012-01-26 16:08 ` Michael Tokarev
2012-01-26 15:01 ` Daniel P. Berrange
2012-01-26 9:50 ` Michael Tokarev
2011-11-26 23:24 [Qemu-devel] Patch to add iSCSI configuration options Ronnie Sahlberg
2011-11-26 23:24 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2011-11-27 8:47 ` Orit Wasserman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F193519.9020605@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).