From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoAoH-0004WU-T0 for qemu-devel@nongnu.org; Fri, 20 Jan 2012 04:31:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoAoD-0005ON-L5 for qemu-devel@nongnu.org; Fri, 20 Jan 2012 04:31:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoAoD-0005OJ-Cx for qemu-devel@nongnu.org; Fri, 20 Jan 2012 04:30:57 -0500 Message-ID: <4F193519.9020605@redhat.com> Date: Fri, 20 Jan 2012 10:34:17 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1324183735-16930-1-git-send-email-ronniesahlberg@gmail.com> <1324183735-16930-2-git-send-email-ronniesahlberg@gmail.com> <4F1809BD.8020108@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: qemu-devel@nongnu.org Am 20.01.2012 09:58, schrieb ronnie sahlberg: > On Thu, Jan 19, 2012 at 11:17 PM, Kevin Wolf wrote: >> Am 18.12.2011 05:48, schrieb Ronnie Sahlberg: >>> This patch adds configuration variables for iSCSI to set >>> initiator-name to use when logging in to the target, >>> which type of header-digest to negotiate with the target >>> and username and password for CHAP authentication. >>> >>> This allows specifying a initiator-name either from the command line >>> -iscsi initiator-name=iqn.2004-01.com.example:test >>> or from a configuration file included with -readconfig >>> [iscsi] >>> initiator-name = iqn.2004-01.com.example:test >>> header-digest = CRC32C|CRC32C-NONE|NONE-CRC32C|NONE >>> user = CHAP username >>> password = CHAP password >>> >>> The patch also updates the manpage and qemu-doc >>> >>> Signed-off-by: Ronnie Sahlberg >> >> So these options are global? What if I wanted to use two different >> setups for two different images? >> > > > Good point. > I will rework the patch so that it first checks for > [iscsi "iqn.target.name"] > and if that is not found it falls-back to just checking for [iscsi] > > That would allow to have one "catch all" section for all targets, but > also the possibility to override and use different settings on a > per-target basis. > > I will post an updated patch in a day or two. Thanks, this sounds like a good solution. Kevin