From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoCTN-0005xB-0y for qemu-devel@nongnu.org; Fri, 20 Jan 2012 06:17:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoCTJ-0000lN-4I for qemu-devel@nongnu.org; Fri, 20 Jan 2012 06:17:32 -0500 Message-ID: <4F194D46.1050501@siemens.com> Date: Fri, 20 Jan 2012 12:17:26 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1327057522-6590-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1327057522-6590-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rename get_clock_realtime List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 2012-01-20 12:05, Paolo Bonzini wrote: > get_clock_realtime accesses the host_clock, not the rt_clock. > > Signed-off-by: Paolo Bonzini > --- > qemu-timer.c | 2 +- > qemu-timer.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qemu-timer.c b/qemu-timer.c > index cd026c6..4a14a6d 100644 > --- a/qemu-timer.c > +++ b/qemu-timer.c > @@ -436,7 +436,7 @@ int64_t qemu_get_clock_ns(QEMUClock *clock) > return cpu_get_clock(); > } > case QEMU_CLOCK_HOST: > - now = get_clock_realtime(); > + now = get_clock_host(); > last = clock->last; > clock->last = now; > if (now < last) { > diff --git a/qemu-timer.h b/qemu-timer.h > index de17f3b..b180fca 100644 > --- a/qemu-timer.h > +++ b/qemu-timer.h > @@ -93,7 +93,7 @@ static inline int64_t get_ticks_per_sec(void) > } > > /* real time host monotonic timer */ > -static inline int64_t get_clock_realtime(void) > +static inline int64_t get_clock_host(void) It accesses the host realtime clock, so get_clock_host_realtime would be optimal. In that light, the comment above should be fixed as well. Jan > { > struct timeval tv; > > @@ -131,7 +131,7 @@ static inline int64_t get_clock(void) > { > /* XXX: using gettimeofday leads to problems if the date > changes, so it should be avoided. */ > - return get_clock_realtime(); > + return get_clock_host(); > } > } > #endif -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux